Skip to content

Add sensors for other ClimaCell data#49259

Merged
raman325 merged 10 commits intohome-assistant:devfrom
raman325:climacell_sensors
Apr 15, 2021
Merged

Add sensors for other ClimaCell data#49259
raman325 merged 10 commits intohome-assistant:devfrom
raman325:climacell_sensors

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Apr 15, 2021

Proposed change

ClimaCell provides a lot of data beyond basic weather data. In this PR we add disabled by default sensors for some of these other data points.

I also noticed that I wasn't rounding in the weather entity when I was doing the conversions, so I went ahead and did that as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Comment thread homeassistant/components/climacell/const.py Outdated
Comment thread homeassistant/components/climacell/const.py Outdated
Comment thread homeassistant/components/climacell/const.py Outdated
Comment thread homeassistant/components/climacell/sensor.py Outdated
Comment thread homeassistant/components/climacell/sensor.py Outdated
Comment thread homeassistant/components/climacell/sensor.py Outdated
Comment thread tests/components/climacell/test_sensor.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Try rebasing on latest dev branch to resolve the error.

@MartinHjelmare
Copy link
Copy Markdown
Member

Please update the ha_category and ha_platforms front matter for the integration docs.

@raman325
Copy link
Copy Markdown
Contributor Author

Please update the ha_category and ha_platforms front matter for the integration docs.

One step ahead of you!

@raman325
Copy link
Copy Markdown
Contributor Author

may have to rebase again after #49271 is merged to get this to pass

@MartinHjelmare
Copy link
Copy Markdown
Member

Build will be fixed by this:
#49271

@raman325 raman325 force-pushed the climacell_sensors branch from 1a3318b to 88b0e6c Compare April 15, 2021 20:00
@raman325 raman325 merged commit 898a1a1 into home-assistant:dev Apr 15, 2021
@raman325 raman325 deleted the climacell_sensors branch April 15, 2021 20:32
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants