Cancel discovery flows that are initializing at shutdown#49241
Merged
bdraco merged 3 commits intoApr 15, 2021
Conversation
Discovery flows that need to request serial numbers or interrogate a device can delay shutdown for multiple minutes
21 tasks
Member
Author
|
Thanks! |
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Apr 15, 2021
Caused by the mid-air collision of home-assistant#49241 and home-assistant#49260
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Cancel discovery flows that are initializing at shutdown
Discovery flows that need to request serial numbers or
interrogate a device can delay shutdown for multiple
minutes which can be longer than the shutdown timeouts in
core'sasync_stop.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: