Skip to content

Cancel discovery flows that are initializing at shutdown#49241

Merged
bdraco merged 3 commits into
home-assistant:devfrom
bdraco:cancel_discovery_flows_shutdown
Apr 15, 2021
Merged

Cancel discovery flows that are initializing at shutdown#49241
bdraco merged 3 commits into
home-assistant:devfrom
bdraco:cancel_discovery_flows_shutdown

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 15, 2021

Proposed change

Cancel discovery flows that are initializing at shutdown

Discovery flows that need to request serial numbers or
interrogate a device can delay shutdown for multiple
minutes which can be longer than the shutdown timeouts in core's async_stop.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Discovery flows that need to request serial numbers or
interrogate a device can delay shutdown for multiple
minutes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 15, 2021

Thanks!

@bdraco bdraco merged commit dafc7a0 into home-assistant:dev Apr 15, 2021
@bdraco bdraco deleted the cancel_discovery_flows_shutdown branch April 15, 2021 17:13
bdraco added a commit to bdraco/home-assistant that referenced this pull request Apr 15, 2021
@bdraco bdraco mentioned this pull request Apr 15, 2021
21 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants