Allow data entry flows to hint for additional steps#49202
Merged
balloob merged 4 commits intohome-assistant:devfrom Apr 23, 2021
Merged
Allow data entry flows to hint for additional steps#49202balloob merged 4 commits intohome-assistant:devfrom
balloob merged 4 commits intohome-assistant:devfrom
Conversation
probot-home-assistant
Bot
added
core
integration: mqtt
new-feature
small-pr
Member
|
This needs to be rebased to include #49260 |
emontnemery
force-pushed
the
data_entry_flow_last_step
branch
from
38cf8a9 to
128b1f8
Compare
KapJI
reviewed
Apr 20, 2021
balloob
reviewed
Apr 22, 2021
| data_schema: vol.Schema = None, | ||
| errors: dict[str, str] | None = None, | ||
| description_placeholders: dict[str, Any] | None = None, | ||
| last_step: bool = True, |
Member
There was a problem hiding this comment.
This seems weird to default to True
Member
There was a problem hiding this comment.
I would expect it to be defaulted to None and typed as bool | None.
Member
There was a problem hiding this comment.
What should be the difference between True and None then?
Member
There was a problem hiding this comment.
None means not set. True/False means the config flow explicitly passed in True/False.
balloob
approved these changes
Apr 23, 2021
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Allow data entry flows to hint for additional steps
The idea is to make it clear to the user when there are additional options available.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: