Add pymodbus exception handling and isolate pymodbus to class modbusHub#49052
Merged
balloob merged 1 commit intohome-assistant:devfrom Apr 19, 2021
janiversen:issue_40936
Merged
Add pymodbus exception handling and isolate pymodbus to class modbusHub#49052balloob merged 1 commit intohome-assistant:devfrom janiversen:issue_40936
balloob merged 1 commit intohome-assistant:devfrom
janiversen:issue_40936
Conversation
|
Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as its been labeled with an integration ( |
This was referenced Apr 11, 2021
Merged
vzahradnik
approved these changes
Apr 14, 2021
Member
Author
|
Update to newest dev which includes changes to modbus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add pymodbus exception handling directly in the class modbusHub in order to isolate the pymodbus library.
This has 2 consequences:
The old code could deliver wrong data during startup, especially if the device were slow to connect, this
Should now be history.
STATE_UNAVIALABLE was not set in all platforms, so sometimes there were not data, but HA was not made aware
That the data was invalid.
There is a major rewrite of the test_modbus.py module, submitted in the next PR, to thoroughly test exceptions/writes etc.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
fixes After restart of Home Assistant Modbus registers sometimes show wrong values until new restart of HA #40936
fixes Modbus: write_register multi #45079
fixes Modbus errors after upgrading to HA v2021.4.0 and new config style #49011
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: