Skip to content

Bump pykodi to 0.2.5#48930

Merged
balloob merged 1 commit intohome-assistant:devfrom
cgtobi:bump_pykodi_025
Apr 9, 2021
Merged

Bump pykodi to 0.2.5#48930
balloob merged 1 commit intohome-assistant:devfrom
cgtobi:bump_pykodi_025

Conversation

@cgtobi
Copy link
Copy Markdown
Contributor

@cgtobi cgtobi commented Apr 9, 2021

Breaking change

Proposed change

Bump pykodi to 0.2.5 to fix issues due to breaking changes in jsonrpc_async, jsonrpc_base and jsonrpc_websocket

OnFreund/PyKodi@v0.2.4...v0.2.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added dependency-bump Pull requests that update a dependency file integration: kodi small-pr PRs with less than 30 lines. by-code-owner labels Apr 9, 2021
@probot-home-assistant
Copy link
Copy Markdown

Hey there @OnFreund, mind taking a look at this pull request as its been labeled with an integration (kodi) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@cgtobi cgtobi added this to the 2021.4.2 milestone Apr 9, 2021
@cgtobi cgtobi added the waiting-for-upstream We're waiting for a change upstream label Apr 9, 2021
@cgtobi cgtobi marked this pull request as ready for review April 9, 2021 12:24
@cgtobi cgtobi removed the waiting-for-upstream We're waiting for a change upstream label Apr 9, 2021
@balloob balloob merged commit ee0c87d into home-assistant:dev Apr 9, 2021
@cgtobi cgtobi deleted the bump_pykodi_025 branch April 9, 2021 16:58
balloob pushed a commit that referenced this pull request Apr 9, 2021
@balloob balloob mentioned this pull request Apr 9, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cherry-picked cla-signed dependency-bump Pull requests that update a dependency file integration: kodi small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MediaBrowser "Error handling message: Unknown error" for Kodi

3 participants