Skip to content

Change discovery timeout from 10 to 60#48924

Merged
pvizeli merged 1 commit intodevfrom
discovery-timeout
Apr 9, 2021
Merged

Change discovery timeout from 10 to 60#48924
pvizeli merged 1 commit intodevfrom
discovery-timeout

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Apr 9, 2021

Breaking change

Adjust the timeout for the retrieve_discovery_messages to 60s instead of the default 10s, this should help with calling this during startup on slower/busy devices.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/supervisor, mind taking a look at this pull request as its been labeled with an integration (hassio) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@pvizeli pvizeli merged commit 65c39bb into dev Apr 9, 2021
@pvizeli pvizeli deleted the discovery-timeout branch April 9, 2021 14:44
@balloob balloob added this to the 2021.4.2 milestone Apr 9, 2021
balloob pushed a commit that referenced this pull request Apr 9, 2021
@balloob balloob mentioned this pull request Apr 9, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants