Skip to content

Add missing super call in Verisure Camera entity #48812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 1 commit into from
Apr 8, 2021
Merged

Add missing super call in Verisure Camera entity #48812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions homeassistant/components/verisure/camera.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def __init__(
):
"""Initialize Verisure File Camera component."""
super().__init__(coordinator)
Camera.__init__(self)
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a super call in the init method of the CoordinatorEntity to make it compatible with multiple inheritence.

Copy link
Copy Markdown
Contributor Author

@JohNan JohNan Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea to me. Are you guys going to do that or do you want me to add it? I'm not sure how it would impact other integrations though.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current fix here is fine to solve it for Verisure.

It would be good to solve it more generally but we should do it separately in that case and add some test cases to make sure it works.

Copy link
Copy Markdown
Member

@frenck frenck Apr 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to solve it more generally

A quick glance at the codebase, this is being solved like this way more often. That is a wider cleanup.

In this case, lets fix it for now for the patch release.


self.serial_number = serial_number
self._directory_path = directory_path
Expand Down