Skip to content

Met.no - only update data if coordinates changed#48756

Merged
frenck merged 2 commits intodevfrom
metno_coordinates
Apr 7, 2021
Merged

Met.no - only update data if coordinates changed#48756
frenck merged 2 commits intodevfrom
metno_coordinates

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Only update the component if the config has changed.
EVENT_CORE_CONFIG_UPDATE is fired twice during startup, so currently, the component is updated three times during startup for the home entity.
Related to #48730

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @thimic, mind taking a look at this pull request as its been labeled with an integration (met) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Danielhiversen Danielhiversen changed the title Met.no - only update coordinates if actually changed Met.no - only update data if coordinates changed Apr 7, 2021
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would be good to add a test for the missing coverage.

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frenck frenck merged commit b558f20 into dev Apr 7, 2021
@frenck frenck deleted the metno_coordinates branch April 7, 2021 07:27
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants