Skip to content

Solve cast delaying startup when discovered devices are slow to setup #48755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emontnemery merged 2 commits into from
Apr 7, 2021
Merged

Solve cast delaying startup when discovered devices are slow to setup #48755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4da4e1f
Solve cast delaying startup when devices are slow to setup
bdraco Apr 7, 2021
db35309
Update homeassistant/components/cast/media_player.py
bdraco Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion homeassistant/components/cast/media_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Provide functionality to interact with Cast devices on the network."""
from __future__ import annotations

import asyncio
from contextlib import suppress
from datetime import timedelta
import functools as ft
Expand Down Expand Up @@ -185,7 +186,9 @@ async def async_added_to_hass(self):
)
self.hass.bus.async_listen_once(EVENT_HOMEASSISTANT_STOP, self._async_stop)
self.async_set_cast_info(self._cast_info)
self.hass.async_create_task(
# asyncio.create_task is used to avoid delaying startup wrapup if the device
Comment thread
MartinHjelmare marked this conversation as resolved.
# is discovered already during startup but then fails to respond
asyncio.create_task(
async_create_catching_coro(self.async_connect_to_chromecast())
)

Expand Down