Do not activate Met.no without setting a Home coordinates#48741
Conversation
|
Hey there @Danielhiversen, @thimic, mind taking a look at this pull request as its been labeled with an integration ( |
|
I think that is a frontend issue, we should not set some things somewhere. But I like the approach to abort it, should also work if we set 0.0 instead amsterdam |
|
I agree this is a frontend issue at some level, however, we currently have a lot of these instances out there. So this is more or less mitigating raised issues/concerns. Should I add |
balloob
left a comment
There was a problem hiding this comment.
This is an ok stop-gap measure for now. Let's get it out asap. We will work on more properly skipping setting a location .
|
Yes, let's also check on 0,0. |
Danielhiversen
left a comment
There was a problem hiding this comment.
Tested, and seems to work correct here 👍
Proposed change
Based on issue #48730, we do a lot of traffic to the Met.no APIs/servers based on the default location. This happens when a user doesn't set a location explicitly during onboarding and causes the core configuration to default to the example data from the frontend:
const amsterdam = [52.3731339, 4.8903147];https://github.com/home-assistant/frontend/blob/109910d18f379e9a23cfc54f3f209e1d06042d72/src/onboarding/onboarding-core-config.ts#L29
Met.no is letting us know that we are in violation of their terms of services. This PR is to mitigate that. For more information see #48730.
Changes:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: