Fix infinite recursion in LazyState#48719
Merged
balloob merged 1 commit intohome-assistant:devfrom Apr 6, 2021
Merged
Conversation
If LazyState cannot parse the attributes of its row as JSON, it prints a message to the logger. Unfortunately, it passes `self` as a format argument to that message, which causes its `__repr__` method to be called, which then tries to retrieve `self.attributes` in order to display them. This leads to an infinite recursion and a crash of the entire core. To fix, send the database row to be printed in the log message, rather than the LazyState object that wraps around it.
probot-home-assistant
Bot
added
bugfix
core
integration: history
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration ( |
balloob
approved these changes
Apr 6, 2021
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Fix is fine. I don't want to know what kind of hacking of database you're doing ;-)
balloob
pushed a commit
that referenced
this pull request
Apr 6, 2021
If LazyState cannot parse the attributes of its row as JSON, it prints a message to the logger. Unfortunately, it passes `self` as a format argument to that message, which causes its `__repr__` method to be called, which then tries to retrieve `self.attributes` in order to display them. This leads to an infinite recursion and a crash of the entire core. To fix, send the database row to be printed in the log message, rather than the LazyState object that wraps around it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
If LazyState cannot parse the attributes of its row as JSON, it prints
a message to the logger. Unfortunately, it passes
selfas a formatargument to that message, which causes its
__repr__method to becalled, which then tries to retrieve
self.attributesin order todisplay them. This leads to an infinite recursion and a crash of the
entire core.
To fix, send the database row to be printed in the log message, rather
than the LazyState object that wraps around it.
Type of change
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: