Skip to content

Abort discovery for unsupported doorbird accessories#48710

Merged
frenck merged 2 commits intohome-assistant:devfrom
bdraco:doorbird_ignore_unsupported
Apr 6, 2021
Merged

Abort discovery for unsupported doorbird accessories#48710
frenck merged 2 commits intohome-assistant:devfrom
bdraco:doorbird_ignore_unsupported

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 6, 2021

Proposed change

Abort discovery for unsupported doorbird accessories

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @oblogic7, mind taking a look at this pull request as its been labeled with an integration (doorbird) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as draft April 6, 2021 04:29
@bdraco bdraco marked this pull request as ready for review April 6, 2021 05:12
@frenck frenck added this to the 2021.4.0 milestone Apr 6, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@frenck frenck merged commit 46b673c into home-assistant:dev Apr 6, 2021
async def test_form_zeroconf_correct_oui_wrong_device(hass, doorbell_state_side_effect):
"""Test we can setup from zeroconf with the correct OUI source but not a doorstation."""
await hass.async_add_executor_job(
init_recorder_component, hass
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why we need to set up the recorder? I don't remember the reason.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember the exact reason but I do remember the tests would fail the CI without it

Let's do an experiment and see if we can take it out #48781

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants