Abort discovery for unsupported doorbird accessories#48710
Merged
frenck merged 2 commits intohome-assistant:devfrom Apr 6, 2021
Merged
Abort discovery for unsupported doorbird accessories#48710frenck merged 2 commits intohome-assistant:devfrom
frenck merged 2 commits intohome-assistant:devfrom
Conversation
| async def test_form_zeroconf_correct_oui_wrong_device(hass, doorbell_state_side_effect): | ||
| """Test we can setup from zeroconf with the correct OUI source but not a doorstation.""" | ||
| await hass.async_add_executor_job( | ||
| init_recorder_component, hass |
Member
There was a problem hiding this comment.
Do you know why we need to set up the recorder? I don't remember the reason.
Member
Author
There was a problem hiding this comment.
I can't remember the exact reason but I do remember the tests would fail the CI without it
Let's do an experiment and see if we can take it out #48781
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Abort discovery for unsupported doorbird accessories
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: