Skip to content

Add modbus write coils#48676

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
janiversen:write_coils
Apr 4, 2021
Merged

Add modbus write coils#48676
MartinHjelmare merged 2 commits intohome-assistant:devfrom
janiversen:write_coils

Conversation

@janiversen
Copy link
Copy Markdown
Member

Breaking change

Proposed change

the function write_coils was missing in ModbusHub. This was detected while writing the pymodbus test cases (soon
to come PR).

ModbusHub setup() contained an empty assert, which are dead code, since voluptuous secures that invalid config values are caught before entering the integration code. Dead code is removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as its been labeled with an integration (modbus) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@janiversen
Copy link
Copy Markdown
Member Author

janiversen commented Apr 4, 2021

@MartinHjelmare I owe you a beer for your patience...the project should enable the possibility to donate beer etc. until the project does it is quite hard to pay my debt.

Problem solved, beer are on its way, thanks again for your patience....I learn a lot and use that when looking at other PRs

write_coils was missing.
The HA configuration secures that CONF_TYPE only contains legal values,
so having an empty assert to catch unknown values is dead code.

An empty assert is not informative.
@MartinHjelmare MartinHjelmare changed the title modbus missing function (this time with the correct branch). Add modbus write coils Apr 4, 2021
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit d5ef382 into home-assistant:dev Apr 4, 2021
@janiversen janiversen deleted the write_coils branch April 4, 2021 20:06
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants