Add modbus write coils#48676
Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom Apr 4, 2021
janiversen:write_coils
Merged
Add modbus write coils#48676MartinHjelmare merged 2 commits intohome-assistant:devfrom janiversen:write_coils
MartinHjelmare merged 2 commits intohome-assistant:devfrom
janiversen:write_coils
Conversation
|
Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as its been labeled with an integration ( |
Member
Author
|
@MartinHjelmare I owe you a beer for your patience...the project should enable the possibility to donate beer etc. until the project does it is quite hard to pay my debt. Problem solved, beer are on its way, thanks again for your patience....I learn a lot and use that when looking at other PRs |
write_coils was missing.
The HA configuration secures that CONF_TYPE only contains legal values, so having an empty assert to catch unknown values is dead code. An empty assert is not informative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
the function write_coils was missing in ModbusHub. This was detected while writing the pymodbus test cases (soon
to come PR).
ModbusHub setup() contained an empty assert, which are dead code, since voluptuous secures that invalid config values are caught before entering the integration code. Dead code is removed.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: