Skip to content

Upgrade holidays to 0.11.1#48673

Merged
frenck merged 1 commit intodevfrom
frenck-2021-1028
Apr 4, 2021
Merged

Upgrade holidays to 0.11.1#48673
frenck merged 1 commit intodevfrom
frenck-2021-1028

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Apr 4, 2021

Proposed change

Upgrades the holidays package to 0.11.1

Changelog: https://github.com/dr-prodigy/python-holidays/blob/master/CHANGES

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
binary_sensor:
  - platform: workday
    country: NL

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added dependency Pull requests marked as a dependency upgrade integration: workday small-pr PRs with less than 30 lines. labels Apr 4, 2021
@frenck frenck merged commit d75f825 into dev Apr 4, 2021
@frenck frenck deleted the frenck-2021-1028 branch April 4, 2021 11:28
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency Pull requests marked as a dependency upgrade integration: workday small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants