Skip to content

Implement Ignore list for poll control configuration on Ikea devices#48667

Merged
balloob merged 3 commits intohome-assistant:devfrom
Adminiuga:fixes/zha-ikea-poll
Apr 5, 2021
Merged

Implement Ignore list for poll control configuration on Ikea devices#48667
balloob merged 3 commits intohome-assistant:devfrom
Adminiuga:fixes/zha-ikea-poll

Conversation

@Adminiuga
Copy link
Copy Markdown
Contributor

Breaking change

No

Proposed change

Don't configure "long_poll_interval" for Ikea devices, as it may cause battery drain.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

n/a

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @dmulcahey, mind taking a look at this pull request as its been labeled with an integration (zha) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Adminiuga Adminiuga added this to the 2021.4.0 milestone Apr 4, 2021
@Adminiuga Adminiuga changed the title Black list poll control on Ikea devices Black list poll control configuration on Ikea devices Apr 4, 2021
@MattWestb
Copy link
Copy Markdown
Contributor

Thanks for implanting the fix !!
I closing the #47567

I think it shall not doing any problems with the blinds but i cant testing then i dont have any of them but it shall being more or less that IKEA is normally is doing in there GW.

@MattWestb MattWestb mentioned this pull request Apr 4, 2021
21 tasks
@joshua-pe
Copy link
Copy Markdown

joshua-pe commented Apr 4, 2021

Awesome. Hope this will make it to 2021.4.0!

@hmmbob
Copy link
Copy Markdown
Contributor

hmmbob commented Apr 4, 2021

@Adminiuga Home Assistant doesn't use the term blacklist anymore. Please rewrite to it's alternative blocklist where applicable.

Fyi; the alternative for whitelist is allowlist by the way.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adminiuga Adminiuga changed the title Black list poll control configuration on Ikea devices Implement Ignore list for poll control configuration on Ikea devices Apr 4, 2021
Comment thread homeassistant/components/zha/core/channels/general.py Outdated
@Adminiuga Adminiuga force-pushed the fixes/zha-ikea-poll branch from 2a0fe1e to 21af2d5 Compare April 4, 2021 14:56
Co-authored-by: Hmmbob <33529490+hmmbob@users.noreply.github.com>
@Adminiuga Adminiuga requested a review from frenck April 4, 2021 14:57
@balloob balloob merged commit 6204765 into home-assistant:dev Apr 5, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 6, 2021
@Adminiuga Adminiuga deleted the fixes/zha-ikea-poll branch August 16, 2021 03:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ikea switches and remotes consume batteries very fast and stop responding after replacing the batteries

8 participants