Implement Ignore list for poll control configuration on Ikea devices#48667
Merged
balloob merged 3 commits intohome-assistant:devfrom Apr 5, 2021
Merged
Implement Ignore list for poll control configuration on Ikea devices#48667balloob merged 3 commits intohome-assistant:devfrom
balloob merged 3 commits intohome-assistant:devfrom
Conversation
|
Hey there @dmulcahey, mind taking a look at this pull request as its been labeled with an integration ( |
Contributor
|
Thanks for implanting the fix !! I think it shall not doing any problems with the blinds but i cant testing then i dont have any of them but it shall being more or less that IKEA is normally is doing in there GW. |
|
Awesome. Hope this will make it to 2021.4.0! |
Contributor
|
@Adminiuga Home Assistant doesn't use the term Fyi; the alternative for |
frenck
requested changes
Apr 4, 2021
hmmbob
reviewed
Apr 4, 2021
2a0fe1e to
21af2d5
Compare
Co-authored-by: Hmmbob <33529490+hmmbob@users.noreply.github.com>
frenck
approved these changes
Apr 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
No
Proposed change
Don't configure "long_poll_interval" for Ikea devices, as it may cause battery drain.
Type of change
Example entry for
configuration.yaml:n/a
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: