Only listen for zeroconf when the esphome device cannot connect#48645
Merged
balloob merged 3 commits intohome-assistant:devfrom Apr 4, 2021
Merged
Only listen for zeroconf when the esphome device cannot connect#48645balloob merged 3 commits intohome-assistant:devfrom
balloob merged 3 commits intohome-assistant:devfrom
Conversation
MartinHjelmare
approved these changes
Apr 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Followup to #48129
I installed beta on a system with ~108 esphome devices and found the executor got overloaded at startup with
2021-04-03 02:47:34 DEBUG (MainThread) [homeassistant.runner] Calling executor with function: <bound method Zeroconf.add_listener of <homeassistant.components.zeroconf.models.HaZeroconf object at 0x7f86f6bae400>>, args: (<homeassistant.components.esphome.ReconnectLogic object at 0x7f86ef8e1460>, None), kwargs: {}Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: