Skip to content

Make modbus WRITE_COIL use write_coils in case of an array#48633

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
janiversen:issue_45750
Apr 3, 2021
Merged

Make modbus WRITE_COIL use write_coils in case of an array#48633
MartinHjelmare merged 2 commits intohome-assistant:devfrom
janiversen:issue_45750

Conversation

@janiversen
Copy link
Copy Markdown
Member

@janiversen janiversen commented Apr 2, 2021

Breaking change

Proposed change

WRITE_REGISTER uses write_register/write_registers depending
on whether value is singular or an array.

WRITE_COIL is modified to be similar and uses
write_coil/write_coils depending on whether value is singular or an
array.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as its been labeled with an integration (modbus) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

WRITE_REGISTER uses write_register/write_registers depending
on whether value is singular or an array.

WRITE_COIL is modified to be similar and uses
write_coil/write_coils depending on whether value is singular or an
array.
@MartinHjelmare MartinHjelmare changed the title make WRITE_COIL use write_coils in case of an array. Make modbus WRITE_COIL use write_coils in case of an array Apr 2, 2021
@home-assistant home-assistant deleted a comment from homeassistant Apr 2, 2021
@home-assistant home-assistant deleted a comment from homeassistant Apr 2, 2021
Comment thread homeassistant/components/modbus/modbus.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Please document this service and link to the docs PR in this PR description.

https://www.home-assistant.io/integrations/modbus/#services

@janiversen
Copy link
Copy Markdown
Member Author

Documentation added (it was actually missing totally for write_coil) and PR updated with link to doc. PR.

@MartinHjelmare
Copy link
Copy Markdown
Member

Thanks!

@MartinHjelmare MartinHjelmare merged commit 23fae25 into home-assistant:dev Apr 3, 2021
@janiversen janiversen deleted the issue_45750 branch April 3, 2021 12:17
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modbus: writeCoil() operation not supported on slave

4 participants