Skip to content

Fix websocket search for related#48603

Merged
balloob merged 2 commits intodevfrom
frenck-2021-1025
Apr 1, 2021
Merged

Fix websocket search for related#48603
balloob merged 2 commits intodevfrom
frenck-2021-1025

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Apr 1, 2021

Proposed change

Fixes

2021-04-01 20:26:24 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [140600048560688] Error handling message: Unknown error
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 18, in _handle_async_response
    await func(hass, connection, msg)
TypeError: object NoneType can't be used in 'await' expression

Introduced in #48499.

Alternatively, we could adjust the @websocket_api.async_response decorator to handle callbacks.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (search) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added this to the 2021.4.0 milestone Apr 1, 2021
@balloob balloob merged commit ceeb060 into dev Apr 1, 2021
@balloob balloob deleted the frenck-2021-1025 branch April 1, 2021 22:31
balloob added a commit that referenced this pull request Apr 1, 2021
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"search/related" websocket api is throwing an execption

3 participants