Skip to content

Add hive heat on demand#48591

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
Pyhass:feature/add-heat-on-demand-support
Apr 1, 2021
Merged

Add hive heat on demand#48591
MartinHjelmare merged 2 commits intohome-assistant:devfrom
Pyhass:feature/add-heat-on-demand-support

Conversation

@KJonline
Copy link
Copy Markdown
Contributor

@KJonline KJonline commented Apr 1, 2021

Breaking change

Proposed change

This change is to add switch support for Hive Heat on Demand functionality whilst updating a couple of function names from pyhiveapi.

Change log for pyhiveapi can be found here.

https://github.com/Pyhive/Pyhiveapi/releases/tag/v0.4.0

And here

https://github.com/Pyhive/Pyhiveapi/releases/tag/v0.4.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Rendili, mind taking a look at this pull request as its been labeled with an integration (hive) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Add Heat on Demand Support Add hive heat on demand Apr 1, 2021
@MartinHjelmare
Copy link
Copy Markdown
Member

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

@KJonline
Copy link
Copy Markdown
Contributor Author

KJonline commented Apr 1, 2021

@MartinHjelmare

Change log has been added 0.4.0 was the main functionality 0.4.1 was the removal of a dependency.

@MartinHjelmare
Copy link
Copy Markdown
Member

Side note: pathlib is available in standard library from Python 3.4:
https://docs.python.org/3/library/pathlib.html

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 6482800 into home-assistant:dev Apr 1, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2021
@KJonline KJonline deleted the feature/add-heat-on-demand-support branch April 5, 2021 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed code-quality dependency Pull requests marked as a dependency upgrade integration: hive new-feature small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants