Skip to content

Return config entry details for 1-step config flows#48585

Merged
emontnemery merged 1 commit intohome-assistant:devfrom
emontnemery:config_flow_fix_return_value
Apr 1, 2021
Merged

Return config entry details for 1-step config flows#48585
emontnemery merged 1 commit intohome-assistant:devfrom
emontnemery:config_flow_fix_return_value

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Return config entry details for 1-step config flows

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (config) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare
Copy link
Copy Markdown
Member

When does the frontend use the index view post request?

@emontnemery
Copy link
Copy Markdown
Contributor Author

emontnemery commented Apr 1, 2021

ConfigManagerFlowIndexView / /api/config/config_entries/flow should be used to initiate a config flow, then ConfigManagerFlowResourceView / /api/config/config_entries/flow/{flow_id} is used when finishing the flow.
@bramkragten can you confirm that's how it's used?

@bramkragten
Copy link
Copy Markdown
Member

When does the frontend use the index view post request?

When we create a new config flow

@emontnemery emontnemery merged commit d26d2a8 into home-assistant:dev Apr 1, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants