Skip to content

Don't care about DPI entries when looking for clients to be restored from UniFi#48579

Merged
Kane610 merged 2 commits into
home-assistant:devfrom
Kane610:unifi-dpi_switches_does_not_have_-_in_uniqueid
Apr 1, 2021
Merged

Don't care about DPI entries when looking for clients to be restored from UniFi#48579
Kane610 merged 2 commits into
home-assistant:devfrom
Kane610:unifi-dpi_switches_does_not_have_-_in_uniqueid

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Apr 1, 2021

Breaking change

Proposed change

Only care about UniFi switch platform entries which belongs to Block or POE switches.
Issue caused by previous refactor because there is minimal coverage of DPI switches today.

Old behavior ignored unique ids without "-" 6f4b8de#diff-d921af131131b83cc821bd00a0e08a532048eaf96344f478586be8aa70daa62eL346

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 added this to the 2021.4.0 milestone Apr 1, 2021
@Kane610 Kane610 changed the title Unifi dpi switches does not have in uniqueid Don't care about DPI entries when looking for clients to be restored from UniFi Apr 1, 2021
@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Apr 1, 2021

Awesome @hunterjm Thanks! 🎉

@Kane610 Kane610 merged commit 6ce96dc into home-assistant:dev Apr 1, 2021
@Kane610 Kane610 deleted the unifi-dpi_switches_does_not_have_-_in_uniqueid branch April 1, 2021 16:02
balloob pushed a commit that referenced this pull request Apr 1, 2021
…from UniFi (#48579)

* DPI switches shouldnt be restored, they're not part of clients to be restored

* Only care about Block and POE switch entries
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unifi integration errors; IndexError: list index out of range

4 participants