Apply Precision/Scale/Offset to struct in modbus sensor#48544
Conversation
|
@vzahradnik did you see this PR ? |
|
Not yet. I probably overlooked it. I will check. |
|
thanks. |
The single values in struct are corrected with presicion, scale and offset, just as it is done with single values.
|
@vzahradnik any comments here ? You wrote in one of your PR´s that you had a comment, and when that was solved you would approve. It would be nice to get this merged alongside your PR´s so we can get modbus moving. |
1 similar comment
|
@vzahradnik any comments here ? You wrote in one of your PR´s that you had a comment, and when that was solved you would approve. It would be nice to get this merged alongside your PR´s so we can get modbus moving. |
|
I know why you did not finalize your review :-) The comment states the value is 1.00e-28 which is a very small number so it converts to 0.00. I did this on purpose to ensure that it worked with very small numbers. |
|
OK, it makes sense now. I will approve. Thanks for clarification. |
|
@MartinHjelmare you changed the title a while ago, do you have other review comments? It would be nice to gave this in the next point release. |

The single values in struct are corrected with presicion, scale and offset,
just as it is done with single values.
Breaking change
Proposed change
the struct configuration e.g.
Could result in very long strings being delivered back, due to many decimal digits.
will cut the decimals to 2.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: