Skip to content

Deprecate SolarEdge YAML configuration#48533

Merged
frenck merged 1 commit intodevfrom
frenck-2021-1015
Mar 31, 2021
Merged

Deprecate SolarEdge YAML configuration#48533
frenck merged 1 commit intodevfrom
frenck-2021-1015

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Mar 31, 2021

Breaking change

The SolarEdge configuration via YAML has been deprecated and will be removed in a future release of Home Assistant. The integration is using a configuration via the UI for two years now.

Existing YAML configurations are automatically imported into the UI, and can be safely removed from your YAML configuration.

Proposed change

  • Add deprecation to YAML configuration
  • Adding myself as codeowner to get notified of issues with this integration

Documentation has been clean up before, so doesn't need to be adjusted.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frenck frenck merged commit d4d8f74 into dev Mar 31, 2021
@frenck frenck deleted the frenck-2021-1015 branch March 31, 2021 08:31
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants