Skip to content

Add opentherm_gw option for setpoint override mode#48465

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
Martidjen:opentherm-gateway-constant-setpoint-mode
Mar 30, 2021
Merged

Add opentherm_gw option for setpoint override mode#48465
MartinHjelmare merged 2 commits intohome-assistant:devfrom
Martidjen:opentherm-gateway-constant-setpoint-mode

Conversation

@Martidjen
Copy link
Copy Markdown
Contributor

@Martidjen Martidjen commented Mar 29, 2021

Proposed change

Added an option to change the setpoint override mode. Temporary setpoint override mode can now be set on or off. 'Constant' setpoint override mode will be used when Temporary is set to off

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Temporary setpoint override mode can now be set on or off. 'Constant' setpoint override mode will be used when Temporary is set to off
@probot-home-assistant
Copy link
Copy Markdown

Hey there @mvn23, mind taking a look at this pull request as its been labeled with an integration (opentherm_gw) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Contributor

@mvn23 mvn23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just one small comment from my side.

Comment thread homeassistant/components/opentherm_gw/climate.py Outdated
Added default value for the setpoint override mode
@MartinHjelmare MartinHjelmare changed the title Adding option for setpoint override mode Add opentherm_gw option for setpoint override mode Mar 30, 2021
@MartinHjelmare
Copy link
Copy Markdown
Member

What does this option mean? Is it not a preset?

@Martidjen
Copy link
Copy Markdown
Contributor Author

Hi.
This option is not a preset, it is used to let the set_temperature option send a different command to the opentherm gateway. Temporary will use the TT= command, constant will use TC=. People familiar with the opentherm gateway will (or should) know these commands. These commands are both included in the pyotgw library, but only TT= was used until now.

When Temporary Setpoint Override Mode is set to on, the thermostat will be able to cancel the setpoint override after a program change. When the option is set to off, the Setpoint Override Mode will be ‘Constant’ and a manual temperature adjustment on the thermostat is needed to cancel the setpoint override.

Am I making any sense? :-)

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 99ab084 into home-assistant:dev Mar 30, 2021
@Martidjen Martidjen deleted the opentherm-gateway-constant-setpoint-mode branch March 30, 2021 07:54
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants