Add id to automation triggers#48464
Merged
bramkragten merged 3 commits intohome-assistant:devfrom Mar 31, 2021
Merged
Conversation
probot-home-assistant
Bot
added
core
integration: homeassistant
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration ( |
balloob
approved these changes
Mar 29, 2021
balloob
reviewed
Mar 30, 2021
Comment on lines
+422
to
+425
| if "trigger" in variables and "id" in variables["trigger"]: | ||
| trigger_path = f"trigger/{variables['trigger']['id']}" | ||
| else: | ||
| trigger_path = "trigger" |
Member
There was a problem hiding this comment.
Note; this is a breaking change and requires a frontend update.
Member
There was a problem hiding this comment.
In what cases do we not have a trigger_Id? It's making things quite complicated
Contributor
Author
There was a problem hiding this comment.
If the automation is force started from the frontend it was not triggered by any of the triggers
balloob
approved these changes
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a
trigger_idto theautomation_infodict and update all triggers to loop that back in the trigger variables.Most device_trigger don't need to be updated as they use an
event,numeric_stateorstatetrigger under the hood.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: