Add asyncio locks to screenlogic api access points#48457
Merged
bdraco merged 3 commits intohome-assistant:devfrom Mar 29, 2021
Merged
Add asyncio locks to screenlogic api access points#48457bdraco merged 3 commits intohome-assistant:devfrom
bdraco merged 3 commits intohome-assistant:devfrom
Conversation
21 tasks
bdraco
approved these changes
Mar 29, 2021
Member
bdraco
left a comment
There was a problem hiding this comment.
LGTM, thanks.
CI failure is unrelated. I restarted it, but it should be good to merge reguardless
API fixes shared socket collision when commands are called by multiple threads.
This reverts commit 870f4bc.
Protects api shared socket collisions/destruction.
4a42d2e to
e26e516
Compare
Member
|
I rebased to I'll merge it as soon as it passes |
Contributor
Author
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add asyncio locks to api access points to protect api's shared socket against collisions/destruction.
FIxes a possible
[Errno 9] Bad file descriptorwhen multiple switches are listed in a single call to switch.toggle/turn_on/turn_offType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: