Skip to content

Fix auth issue for non-2FA iCloud accounts#48455

Merged
bdraco merged 1 commit into
home-assistant:devfrom
nzapponi:icloud-2fa-fix
Mar 30, 2021
Merged

Fix auth issue for non-2FA iCloud accounts#48455
bdraco merged 1 commit into
home-assistant:devfrom
nzapponi:icloud-2fa-fix

Conversation

@nzapponi
Copy link
Copy Markdown
Contributor

Proposed change

Fix issue for iCloud users without 2FA which have been unable to log in. See #46054.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Quentame, mind taking a look at this pull request as its been labeled with an integration (icloud) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Fixed auth issue for non-2FA iCloud accounts Fix auth issue for non-2FA iCloud accounts Mar 29, 2021
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdraco bdraco merged commit fc8dc03 into home-assistant:dev Mar 30, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iCloud devices became unavailable after installing 2021.2.1

4 participants