Skip to content

Bump HAP-python to 3.4.1 for homekit#48444

Merged
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:homekit_hap_bump
Mar 28, 2021
Merged

Bump HAP-python to 3.4.1 for homekit#48444
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:homekit_hap_bump

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 28, 2021

Proposed change

Bump HAP-python to 3.4.1 for homekit

Changelog: https://github.com/ikalchev/HAP-python/pull/339/files

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added integration: homekit small-pr PRs with less than 30 lines. dependency-bump Pull requests that update a dependency file by-code-owner labels Mar 28, 2021
Copy link
Copy Markdown
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 28, 2021

Thanks!

@bdraco bdraco merged commit a7d0fc2 into home-assistant:dev Mar 28, 2021
@bdraco bdraco deleted the homekit_hap_bump branch March 28, 2021 21:57
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency-bump Pull requests that update a dependency file integration: homekit small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants