Skip to content

Fix mysensors default persistence file on import#48410

Merged
frenck merged 2 commits intodevfrom
fix-mysensors-default-persistence-path
May 7, 2021
Merged

Fix mysensors default persistence file on import#48410
frenck merged 2 commits intodevfrom
fix-mysensors-default-persistence-path

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare commented Mar 27, 2021

Breaking change

Proposed change

  • We missed to migrate the default persistence file on config import when introducing config entries. This PR fixes that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @functionpointer, mind taking a look at this pull request as its been labeled with an integration (mysensors) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare force-pushed the fix-mysensors-default-persistence-path branch from 16a4330 to ecdebf5 Compare April 23, 2021 09:29
@MartinHjelmare MartinHjelmare force-pushed the fix-mysensors-default-persistence-path branch from ecdebf5 to 31d8fc9 Compare April 27, 2021 10:20
@MartinHjelmare MartinHjelmare added this to the 2021.5.1 milestone May 7, 2021
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frenck frenck merged commit 0c288bc into dev May 7, 2021
@frenck frenck deleted the fix-mysensors-default-persistence-path branch May 7, 2021 11:37
@frenck frenck mentioned this pull request May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mysensors sensors missing since 2021.3.0, serial gateway

4 participants