Skip to content

Clean up superfluous integration setup - part 1#48397

Closed
frenck wants to merge 4 commits intodevfrom
frenck-2021-0979
Closed

Clean up superfluous integration setup - part 1#48397
frenck wants to merge 4 commits intodevfrom
frenck-2021-0979

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Mar 27, 2021

🚫 Depends on / Blocked by #48381, needs to be rebased after that one is merged.

Proposed change

#48381 remove the need for an integration setup or async_setup in case the integration provides a async_setup_entry. For example:

async def async_setup(hass, config):
    """Component setup, do nothing."""
    return True

This PR is cleanup for those.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck changed the title Make integration setup optional Clean up superfluous integration setup - part 1 Mar 27, 2021
@MartinHjelmare
Copy link
Copy Markdown
Member

Can we wait with these until the dependency is merged?

@MartinHjelmare
Copy link
Copy Markdown
Member

At this point they are just spam since I assume you're not looking for advice on the code.

@frenck
Copy link
Copy Markdown
Member Author

frenck commented Mar 27, 2021

At this point they are just spam since I assume you're not looking for advice on the code.

I am.

@frenck frenck marked this pull request as ready for review March 27, 2021 10:27
@MartinHjelmare
Copy link
Copy Markdown
Member

What do you want advice on?

@frenck
Copy link
Copy Markdown
Member Author

frenck commented Mar 27, 2021

It is ready for review, as I'm done on my end.

@MartinHjelmare
Copy link
Copy Markdown
Member

We can't do a proper review until it's rebased. We don't even know if the dependency will be merged yet. So unless there's a specific question this PR is not needed until the dependency is merged, in my opinion.

@frenck frenck closed this Mar 27, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 28, 2021
@home-assistant home-assistant unlocked this conversation Mar 29, 2021
@home-assistant home-assistant locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants