Skip to content

Lazy load broadlink storage#48391

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
bdraco:broadlink_lazy_load_storage
Mar 27, 2021
Merged

Lazy load broadlink storage#48391
MartinHjelmare merged 1 commit intohome-assistant:devfrom
bdraco:broadlink_lazy_load_storage

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 27, 2021

Proposed change

Delay loading storage until it is needed.

With many broadlink devices (12), the storage load, in combination with
other integrations, overwhelmed the executor at startup.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

With many broadlink devices, the storage load overwhelmed the
executor at startup. Delay loading storage until it is needed.
@probot-home-assistant probot-home-assistant Bot added integration: broadlink small-pr PRs with less than 30 lines. labels Mar 27, 2021
@bdraco bdraco marked this pull request as ready for review March 27, 2021 06:15
@probot-home-assistant
Copy link
Copy Markdown

Hey there @Danielhiversen, @felipediel, mind taking a look at this pull request as its been labeled with an integration (broadlink) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@felipediel
Copy link
Copy Markdown
Contributor

Looks good!

@MartinHjelmare MartinHjelmare merged commit 9737480 into home-assistant:dev Mar 27, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants