Skip to content

Move cast config flow tests to test_config_flow#48362

Merged
emontnemery merged 1 commit intohome-assistant:devfrom
emontnemery:cast_move_tests
Apr 1, 2021
Merged

Move cast config flow tests to test_config_flow#48362
emontnemery merged 1 commit intohome-assistant:devfrom
emontnemery:cast_move_tests

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Mar 26, 2021

Proposed change

Move cast config flow tests to test_config_flow as suggested here: https://github.com/home-assistant/core/pull/47269/files#pullrequestreview-620835556

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests that are not testing the result of a flow should stay in the test_init.py module, eg test_import.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emontnemery emontnemery merged commit 2bf91fa into home-assistant:dev Apr 1, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 2, 2021
@emontnemery emontnemery added this to the 2021.4.4 milestone Apr 11, 2021
@emontnemery
Copy link
Copy Markdown
Contributor Author

Tagging for 2021.4 to allow cherry-picking #49051

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants