Migrate template to register reload service on async_setup#48273
Merged
Conversation
probot-home-assistant
Bot
added
has-tests
integration: template
small-pr
balloob
commented
Mar 24, 2021
| import homeassistant.util.dt as dt_util | ||
|
|
||
| from tests.common import assert_setup_component, async_fire_time_changed | ||
| from tests.common import async_fire_time_changed |
Member
Author
There was a problem hiding this comment.
This file is just whitespace changes: https://github.com/home-assistant/core/pull/48273/files?w=1
I removed assert_setup_component which is 🤷 and it broke now template was another component set up.
bdraco
approved these changes
Mar 24, 2021
Member
bdraco
left a comment
bdraco
left a comment
There was a problem hiding this comment.
LGTM. Tested and verified reload still works 👍
Member
|
CI failed because of the frontend pypi not being published. I restarted it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add an
async_setupto the template integration that registers the reload service.In preparation of adding #48169 on top.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: