Add Rituals Perfume Genie sensor platform#48270
Merged
bdraco merged 12 commits intohome-assistant:devfrom Apr 11, 2021
Merged
Conversation
8 tasks
bdraco
reviewed
Mar 31, 2021
bdraco
reviewed
Mar 31, 2021
bdraco
reviewed
Mar 31, 2021
Contributor
|
Verified - current code is successfully adding new sensors for Genie v2 (which does not have a battery)
|
bdraco
reviewed
Apr 4, 2021
bdraco
reviewed
Apr 4, 2021
bdraco
reviewed
Apr 4, 2021
milanmeu
force-pushed
the
add-rituals-sensor-platform
branch
from
3a78e0f to
d7c96ca
Compare
Contributor
Author
|
I made the requested changes and had to do a rebase for d7c96ca. Failing tests: |
21 tasks
bdraco
requested changes
Apr 10, 2021
Member
bdraco
left a comment
bdraco
left a comment
There was a problem hiding this comment.
Please resolve conflicts. Thanks!
bdraco
reviewed
Apr 11, 2021
bdraco
reviewed
Apr 11, 2021
bdraco
requested changes
Apr 11, 2021
Member
bdraco
left a comment
bdraco
left a comment
There was a problem hiding this comment.
Please remove the icon for any entity with device_class
https://developers.home-assistant.io/docs/core/entity/#advanced-properties
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
reviewed
Apr 11, 2021
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please address the comments in a new PR. Thanks!
| def extra_state_attributes(self): | ||
| """Return the wifi state attributes.""" | ||
| return { | ||
| ATTR_SIGNAL_STRENGTH: self.coordinator.data[HUB][SENSORS][WIFI][TITLE], |
Member
There was a problem hiding this comment.
What measurement is this?
Contributor
Author
There was a problem hiding this comment.
Same as the battery. The description of the state as shown in the app: low, medium, ...
Member
There was a problem hiding this comment.
Remove it completely or make it a separate sensor entity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds the sensor platform to the
rituals_perfume_genieintegration.DiffuserEntityclass:DiffuserSwitchextendsDiffuserEntityDiffuserEntityDataUpdateCoordinator:DataUpdateCoordinatorasync_updatefromDiffuserSwitchasync_forward_entry_setupType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: