Include platform only integrations in the manifest list api#48269
Include platform only integrations in the manifest list api#48269MartinHjelmare merged 2 commits intohome-assistant:devfrom
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration ( |
Ensure legacy device trackers get add to hass.config.components as they were previously all called device_tracker.legacy
7ea8743 to
a641be5
Compare
| ATTR_COMPONENT = "component" | ||
|
|
||
| BASE_PLATFORMS = { | ||
| "alarm_control_panel", |
There was a problem hiding this comment.
air_quality is missing and notify too even though it isn't an entity component.
There was a problem hiding this comment.
It's a bit annoying that we need to remember to extend this list when we add a new base entity integration. Could we extend the manifest for this purpose? @balloob?
There was a problem hiding this comment.
air_quality is missing and notify too even though it isn't an entity component.
Good catch. Will add them.
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good!
My comment about extracting the base integration list to the manifests can be a follow up if we think it's worthwhile.
Proposed change
This should solve the bug reports that are missing some integrations
which make them ridiculously hard to track down.
Integrations that are platform only are missing from
the
/config/infopage. A frontend change is needed to address this,and a
corechange (this change) is needed to provide the manifest data.Include integrations that are platform only in the manifest list api
Ensure legacy device trackers get add to
hass.config.componentsasthey were previously all called
device_tracker.legacy. exdevice_tracker.pingis now in the list.frontend: home-assistant/frontend#8698
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: