Skip to content

Include platform only integrations in the manifest list api#48269

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
bdraco:missing_manifests
Mar 29, 2021
Merged

Include platform only integrations in the manifest list api#48269
MartinHjelmare merged 2 commits intohome-assistant:devfrom
bdraco:missing_manifests

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 23, 2021

Proposed change

This should solve the bug reports that are missing some integrations
which make them ridiculously hard to track down.

Integrations that are platform only are missing from
the /config/info page. A frontend change is needed to address this,
and a core change (this change) is needed to provide the manifest data.

Include integrations that are platform only in the manifest list api

Ensure legacy device trackers get add to hass.config.components as
they were previously all called device_tracker.legacy. ex
device_tracker.ping is now in the list.

frontend: home-assistant/frontend#8698

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (websocket_api) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Ensure legacy device trackers get add to hass.config.components as
they were previously all called device_tracker.legacy
@bdraco bdraco force-pushed the missing_manifests branch from 7ea8743 to a641be5 Compare March 27, 2021 14:52
Comment thread homeassistant/setup.py
ATTR_COMPONENT = "component"

BASE_PLATFORMS = {
"alarm_control_panel",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

air_quality is missing and notify too even though it isn't an entity component.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit annoying that we need to remember to extend this list when we add a new base entity integration. Could we extend the manifest for this purpose? @balloob?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

air_quality is missing and notify too even though it isn't an entity component.

Good catch. Will add them.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

My comment about extracting the base integration list to the manifests can be a follow up if we think it's worthwhile.

@MartinHjelmare MartinHjelmare changed the title Include integrations that are platform only in the manifest list api Include platform only integrations in the manifest list api Mar 29, 2021
@MartinHjelmare MartinHjelmare merged commit 1fb9008 into home-assistant:dev Mar 29, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants