Refactor tracing: Prepare for tracing of scripts#48231
Merged
balloob merged 1 commit intohome-assistant:devfrom Mar 23, 2021
Merged
Refactor tracing: Prepare for tracing of scripts#48231balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
balloob
approved these changes
Mar 23, 2021
balloob
reviewed
Mar 23, 2021
| @@ -23,7 +23,7 @@ class AutomationTrace: | |||
|
|
|||
| def __init__( | |||
Member
There was a problem hiding this comment.
Shouldn't we move this one to trace integration too ?
balloob
reviewed
Mar 24, 2021
Comment on lines
+75
to
+76
| vol.Inclusive("domain", "id"): vol.In(TRACE_DOMAINS), | ||
| vol.Inclusive("item_id", "id"): str, |
Member
There was a problem hiding this comment.
Why are these inclusive? I don't think I ever want to get all traces from both scrips and automation at the same time.
9 tasks
This was referenced Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Refactor tracing: Prepare for tracing of scripts by using neutral language and variable names in shared trace related functions.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: