Skip to content

Improve Docker and Kubernetes support for KNX#48065

Merged
frenck merged 5 commits into
home-assistant:devfrom
plomosits:dev
Mar 22, 2021
Merged

Improve Docker and Kubernetes support for KNX#48065
frenck merged 5 commits into
home-assistant:devfrom
plomosits:dev

Conversation

@plomosits
Copy link
Copy Markdown
Contributor

@plomosits plomosits commented Mar 18, 2021

Proposed change

Improve Docker and Kubernetes support for KNX by adding new XKNX parameter "route_back" to Home-Assistant configuration.
With this small change it is possible to use Home-Assistant with KNX on Kubernetes.
It is also possible to run Home-Assistant with KNX on a Docker host without using "network=host" as described at https://www.home-assistant.io/installation/linux#install-home-assistant-container

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
knx:
  tunneling:
    host: '192.168.0.xxx'
    local_ip: '0.0.0.0'
    route_back: true

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @plomosits,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Julius2342, @farmio, @marvin-w, mind taking a look at this pull request as its been labeled with an integration (knx) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Comment thread homeassistant/components/knx/schema.py Outdated
Comment thread homeassistant/components/knx/__init__.py Outdated
plomosits and others added 4 commits March 18, 2021 08:37
@agners
Copy link
Copy Markdown
Member

agners commented Mar 22, 2021

This looks good to me but needs a documentation update in https://github.com/home-assistant/home-assistant.io/blob/current/source/_integrations/knx.markdown.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation PR is open, it needs a rebase, but will keep track on that from the docs repo.

✅ LGTM, merging this end.

@frenck frenck merged commit 18e6816 into home-assistant:dev Mar 22, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants