Skip to content

Add samsungtv dhcp and zeroconf discovery#48022

Merged
bdraco merged 111 commits intohome-assistant:devfrom
chemelli74:chemelli74-samsungtv
May 22, 2021
Merged

Add samsungtv dhcp and zeroconf discovery#48022
bdraco merged 111 commits intohome-assistant:devfrom
chemelli74:chemelli74-samsungtv

Conversation

@chemelli74
Copy link
Copy Markdown
Contributor

@chemelli74 chemelli74 commented Mar 17, 2021

Proposed change

Add samsungtv zeroconf discovery from @escoand (see initial PR #35773 and PR ##47715)

Added few code cleanup, better ignore device handling and Soundbar filtering

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @escoand, mind taking a look at this pull request as its been labeled with an integration (samsungtv) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@chemelli74
Copy link
Copy Markdown
Contributor Author

@balloob , here the new PR. Sorry again for the mistake.

Simone

@chemelli74 chemelli74 force-pushed the chemelli74-samsungtv branch from ef19da9 to e125ced Compare March 30, 2021 17:37
Comment thread homeassistant/components/samsungtv/bridge.py Outdated
Comment thread homeassistant/components/samsungtv/config_flow.py Outdated
Comment thread homeassistant/components/samsungtv/config_flow.py
Comment thread homeassistant/components/samsungtv/config_flow.py Outdated
Comment thread homeassistant/components/samsungtv/config_flow.py Outdated
@bdraco bdraco self-requested a review April 4, 2021 18:02
Comment thread homeassistant/components/samsungtv/config_flow.py
Comment thread homeassistant/components/samsungtv/strings.json Outdated
Comment thread homeassistant/components/samsungtv/strings.json Outdated
Comment thread homeassistant/components/samsungtv/strings.json Outdated
Comment thread tests/components/samsungtv/test_media_player.py Outdated
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments above

Comment thread homeassistant/components/samsungtv/config_flow.py
Comment thread homeassistant/components/samsungtv/config_flow.py Outdated
Comment thread homeassistant/components/samsungtv/config_flow.py Outdated
Comment thread homeassistant/components/samsungtv/config_flow.py Outdated
Comment thread homeassistant/components/samsungtv/config_flow.py
@chemelli74 chemelli74 requested a review from bdraco April 5, 2021 11:52
Comment thread homeassistant/components/samsungtv/config_flow.py Outdated
Comment thread homeassistant/components/samsungtv/media_player.py Outdated
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments above

@chemelli74 chemelli74 force-pushed the chemelli74-samsungtv branch from 882bd46 to 97f2dfe Compare April 6, 2021 09:54
Comment thread homeassistant/components/samsungtv/config_flow.py Outdated
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 21, 2021

Hmm.. reauth doesn't actually work

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 21, 2021

Screen Shot 2021-05-21 at 3 17 04 PM

Fixed reauth

Comment thread homeassistant/components/samsungtv/manifest.json Outdated
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 22, 2021

I've tested this with 6 different samsung tv models (with airplay turned on and off) and everything is working as expected.

@bdraco bdraco changed the title Add samsungtv zeroconf discovery Add samsungtv dhcp and zeroconf discovery May 22, 2021
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 22, 2021

Now that we have the mac we can fix the turn on support in a new pr with wakeonlan

@bdraco bdraco merged commit b9a0fb9 into home-assistant:dev May 22, 2021
@chemelli74 chemelli74 deleted the chemelli74-samsungtv branch May 22, 2021 17:47
@github-actions github-actions Bot locked and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.109.b4: Samsung sound bar detected as TV

6 participants