Add color_mode support to MQTT JSON light#47993
Merged
frenck merged 4 commits intohome-assistant:devfrom Mar 31, 2021
Merged
Conversation
Contributor
Author
|
@Koenkk Can you please help to review this change? |
21 tasks
Contributor
|
Looks good, no comments from my side. |
Contributor
Author
|
@Koenkk Are you OK with the non-symmetric way For example, the light will get this command: {"state": "ON", "color": {"h": 359.0, "s": 78.0}, "brightness": 75}To which the expected state update from the light is: {"state": "ON", "color_mode": "hs", "color": {"h": 359.0, "s": 78.0}, "brightness": 75}This means the light may include some additional data, such as |
Contributor
|
@emontnemery yes! |
frenck
reviewed
Mar 31, 2021
frenck
approved these changes
Mar 31, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
MQTT JSON light now supports
color_modewhich should be used together withsupported_color_modesto signal the light's features.Feature flags
color_temp,hs,rgb,white_value,xyare all deprecated and support will be removed in 2021.10.Proposed change
Add
color_modesupport to MQTT JSON light.color_modewill not be sent to the light on the command topic, the light can unambiguously deduce the desired color made based on which values are present in thecolordict or ifcolor_tempis present.The light must report a supported
color_modein it's state update if the state update includes acolordict or ifcolor_tempis present.Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: