Skip to content

Fix update of surveillance_station data in Synology DSM #47966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 1 commit into from
Mar 31, 2021
+3 −12
Merged

Fix update of surveillance_station data in Synology DSM #47966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions homeassistant/components/synology_dsm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,12 +441,11 @@ def _async_setup_api_requests(self):
)
return

# surveillance_station is updated by own coordinator
self.dsm.reset(self.surveillance_station)

# Determine if we should fetch an API
self._with_system = bool(self.dsm.apis.get(SynoCoreSystem.API_KEY))
self._with_surveillance_station = bool(
self.dsm.apis.get(SynoSurveillanceStation.CAMERA_API_KEY)
) or bool(self.dsm.apis.get(SynoSurveillanceStation.HOME_MODE_API_KEY))

self._with_security = bool(
self._fetching_entities.get(SynoCoreSecurity.API_KEY)
)
Expand Down Expand Up @@ -497,14 +496,6 @@ def _async_setup_api_requests(self):
self.dsm.reset(self.utilisation)
self.utilisation = None

if not self._with_surveillance_station:
_LOGGER.debug(
"Disable surveillance_station api from being updated for '%s'",
self._entry.unique_id,
)
self.dsm.reset(self.surveillance_station)
self.surveillance_station = None

def _fetch_device_configuration(self):
"""Fetch initial device config."""
self.information = self.dsm.information
Expand Down