Recorder improvements#47739
Merged
Merged
Conversation
* Merge disconnect_states and purge_state_ids * Convert namedtuple * Add additional typing information
d75bfde to
8b87974
Compare
8b87974 to
030c10f
Compare
Member
|
Good to review, or should I wait for more changes? |
Member
Author
|
@bdraco It's ready for review. Just hope that the tests pass this time. Had one that was a bit flaky (although it worked flawlessly on my machine). If I need to modify something, it will be with a normal commit from now on. |
Member
Author
|
CI tests are passing now as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Some improvements to the recorder component and its tests in preparation for #45826
Besides some minor typing changes and new test helper functions, the biggest change is that I combined
_disconnect_states_about_to_be_purgedand_purge_state_idssince I noticed that both should and always will be called together.--
cc: @bdraco
Type of change
Additional information
Checklist
black --fast homeassistant tests)