Skip to content

Recorder improvements#47739

Merged
bdraco merged 4 commits into
home-assistant:devfrom
cdce8p:recorder-improvements
Mar 11, 2021
Merged

Recorder improvements#47739
bdraco merged 4 commits into
home-assistant:devfrom
cdce8p:recorder-improvements

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Mar 10, 2021

Proposed change

Some improvements to the recorder component and its tests in preparation for #45826

Besides some minor typing changes and new test helper functions, the biggest change is that I combined _disconnect_states_about_to_be_purged and _purge_state_ids since I noticed that both should and always will be called together.

--
cc: @bdraco

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

cdce8p added 2 commits March 10, 2021 22:37
* Merge disconnect_states and purge_state_ids
* Convert namedtuple
* Add additional typing information
@cdce8p cdce8p force-pushed the recorder-improvements branch from 8b87974 to 030c10f Compare March 11, 2021 16:49
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 11, 2021

Good to review, or should I wait for more changes?

@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Mar 11, 2021

@bdraco It's ready for review. Just hope that the tests pass this time. Had one that was a bit flaky (although it worked flawlessly on my machine). If I need to modify something, it will be with a normal commit from now on.

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing locally.

@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Mar 11, 2021

CI tests are passing now as well

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bdraco bdraco merged commit 10848b9 into home-assistant:dev Mar 11, 2021
@cdce8p cdce8p deleted the recorder-improvements branch March 11, 2021 17:54
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants