Add ClimaCell v4 API support#47575
Merged
raman325 merged 17 commits intohome-assistant:devfrom Apr 5, 2021
Merged
Conversation
Contributor
|
Looks like there's a merge conflict. |
Contributor
Author
thanks! |
|
This is great. Thanks @raman325 |
MartinHjelmare
requested changes
Apr 5, 2021
8 tasks
Member
|
Opened missing documentation PR here: home-assistant/home-assistant.io#17291 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When I first wrote the
climacellintegration, v3 was the only API version available and therefore the only one supported. By the time the integration released, v3 was deprecated and v4 is the only API version that new users can sign up for. This update adds v4 support to the integration (v4 is completely different from v3 so it's almost like writing a new integration). v3 is still active but will be retired in July, so I positioned the change such that it will be easy to remove support for v3 when that occursSummary of changes (this PR looks bigger than it is)
pyclimacell. Effectively I just renamed the existing classes to V3 versions and then added V4 classes. I also added a new function for V4 that grabs all of the data in the format we expect to reduce the burden on the integration. Changelog: raman325/pyclimacell@v0.14.0...v0.18.0api_versionkey to the config entry data.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: