Skip to content

KNX remove custom deprecation warnings#47238

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
farmio:deprecate-config_file
Mar 2, 2021
Merged

KNX remove custom deprecation warnings#47238
MartinHjelmare merged 1 commit into
home-assistant:devfrom
farmio:deprecate-config_file

Conversation

@farmio
Copy link
Copy Markdown
Member

@farmio farmio commented Mar 1, 2021

Proposed change

  • use cv.deprecated instead of custom deprecation warnings with links to external sites

This is a follow-up for #46874 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as its been labeled with an integration (knx) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@farmio farmio mentioned this pull request Mar 1, 2021
21 tasks
@MartinHjelmare
Copy link
Copy Markdown
Member

Please start on a fresh branch based on latest dev.

@farmio farmio force-pushed the deprecate-config_file branch from f6e3071 to c039ae9 Compare March 2, 2021 05:26
@farmio
Copy link
Copy Markdown
Member Author

farmio commented Mar 2, 2021

Did a reset and cherry-pick.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit ce8871e into home-assistant:dev Mar 2, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2021
@farmio farmio deleted the deprecate-config_file branch May 31, 2021 05:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants