Ensure HA script and Python script services have a name#47204
Merged
frenck merged 4 commits intohome-assistant:devfrom Mar 31, 2021
Merged
Ensure HA script and Python script services have a name#47204frenck merged 4 commits intohome-assistant:devfrom
frenck merged 4 commits intohome-assistant:devfrom
Conversation
This was referenced Feb 28, 2021
frenck
requested changes
Mar 1, 2021
Member
frenck
left a comment
There was a problem hiding this comment.
You should not handle multiple things in a single PR.
Please strip out the refactoring into a separate PR.
cf5fa00 to
9464cb4
Compare
Member
|
There is a merge conflict @spacegaier |
Member
Author
Resolved. |
frenck
requested changes
Mar 30, 2021
Co-authored-by: Franck Nijhof <git@frenck.dev>
frenck
reviewed
Mar 30, 2021
Member
frenck
left a comment
There was a problem hiding this comment.
Looks good, only thing missing is tests.
- A test case needs to be added for testing the name parameter in scripts
- A test case needs to be extended for the python_script integration to test the name parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
For HA scripts and Python scripts the backend automatically generates a matching service to trigger them. However, these services currently do not get a name, which however in frontend PR home-assistant/frontend#8493 we would like to show to the user.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
nameproperty for services.yaml home-assistant.io#16788Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: