Uniformize platform setup#47101
Merged
Merged
Conversation
balloob
approved these changes
Feb 26, 2021
Member
balloob
left a comment
There was a problem hiding this comment.
This change is fine when the tests pass 👍
This comment has been minimized.
This comment has been minimized.
54e7d87 to
91c6089
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Global changes about naming to setup a platform, often the term "component" is used, and even some times "domain", globally, the changes are :
for component in PLATFORMSfor component in COMPONENTSfor component in [X]_COMPONENTSfor domain in DOMAINSfor domain in [X]_DOMAINSNow ==>
for platform in PLATFORMSI also created
PLATFORMSconst when having list of platforms into the foreach (likeverisure).Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: