Skip to content

Sort supported features in vlc_telnet#46800

Merged
MartinHjelmare merged 5 commits intohome-assistant:devfrom
dmcc:volume-step
Mar 15, 2021
Merged

Sort supported features in vlc_telnet#46800
MartinHjelmare merged 5 commits intohome-assistant:devfrom
dmcc:volume-step

Conversation

@dmcc
Copy link
Copy Markdown
Contributor

@dmcc dmcc commented Feb 20, 2021

Proposed change

Extracted from #44776.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Cleanup: sort SUPPORT_VLC elements.
@probot-home-assistant
Copy link
Copy Markdown

Hey there @rodripf, mind taking a look at this pull request as its been labeled with an integration (vlc_telnet) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Comment thread homeassistant/components/vlc_telnet/media_player.py Outdated
@dmcc dmcc requested a review from MartinHjelmare February 26, 2021 23:30
Comment thread homeassistant/components/vlc_telnet/media_player.py Outdated
@dmcc dmcc requested a review from MartinHjelmare February 28, 2021 19:28
Comment thread homeassistant/components/vlc_telnet/media_player.py Outdated
Comment thread homeassistant/components/vlc_telnet/media_player.py
@dmcc dmcc requested a review from MartinHjelmare March 2, 2021 02:00
The base media entity implementation works fine.
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just clean up the import and we're good. 👍

@MartinHjelmare MartinHjelmare changed the title Add volume step support to vlc_telnet Sort supported features in vlc_telnet Mar 5, 2021
@dmcc dmcc changed the title Sort supported features in vlc_telnet Sort supported_features elements in vlc_telnet Mar 5, 2021
@dmcc
Copy link
Copy Markdown
Contributor Author

dmcc commented Mar 5, 2021

Oops, didn't mean to clobber your title change.

@dmcc dmcc changed the title Sort supported_features elements in vlc_telnet Sort supported features in vlc_telnet Mar 5, 2021
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dmcc dmcc requested a review from bramkragten March 8, 2021 01:03
@MartinHjelmare MartinHjelmare merged commit 37c53e0 into home-assistant:dev Mar 15, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants