Skip to content

Add Xiaomi Miio subdevice lightbulb support#46660

Merged
MartinHjelmare merged 7 commits into
home-assistant:devfrom
starkillerOG:Miio_subdevices_light
Mar 14, 2021
Merged

Add Xiaomi Miio subdevice lightbulb support#46660
MartinHjelmare merged 7 commits into
home-assistant:devfrom
starkillerOG:Miio_subdevices_light

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Feb 16, 2021

Breaking change

Proposed change

Add support for all zigbee lightbulbs connected to a xiaomi gateway:

  • lumi.light.aqcn02
  • ikea.light.led1545g12
  • ikea.light.led1546g12
  • ikea.light.led1536g5
  • ikea.light.led1537r6
  • ikea.light.led1623g12
  • ikea.light.led1650r5
  • ikea.light.led1649c5

Python-miio version bump:
https://github.com/rytilahti/python-miio/releases/tag/0.5.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Config flow

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with an integration (xiaomi_miio) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@rytilahti could you release a new version of Python-miio so also this PR can be merged?

@starkillerOG
Copy link
Copy Markdown
Contributor Author

Failing tests are unrelated.

@MartinHjelmare MartinHjelmare changed the title Xiaomi Miio: add subdevice lightbulb support Add Xiaomi Miio subdevice lightbulb support Feb 17, 2021
@MartinHjelmare MartinHjelmare added the waiting-for-upstream We're waiting for a change upstream label Feb 17, 2021
Comment thread homeassistant/components/xiaomi_miio/light.py Outdated
@starkillerOG
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare Could you review again/approve?

@MartinHjelmare
Copy link
Copy Markdown
Member

Looks good! I'll do a final review when the library is bumped.

@rytilahti rytilahti removed the waiting-for-upstream We're waiting for a change upstream label Mar 13, 2021
@rytilahti
Copy link
Copy Markdown
Member

rytilahti commented Mar 13, 2021

I have just released python-miio 0.5.5 on pypi, so this can proceed @starkillerOG.

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare can you merge this (already approved by you)?

@MartinHjelmare MartinHjelmare merged commit 50b5fc4 into home-assistant:dev Mar 14, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants