Skip to content

Add support for custom themes to use dark mode#46532

Merged
spacegaier merged 12 commits intohome-assistant:devfrom
spacegaier:custom-dark-themes
May 25, 2021
Merged

Add support for custom themes to use dark mode#46532
spacegaier merged 12 commits intohome-assistant:devfrom
spacegaier:custom-dark-themes

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Feb 14, 2021

Breaking change

Proposed change

Frontend PR: home-assistant/frontend#8347

Extends the frontend theme schema to support specifying dark mode based themes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/frontend, mind taking a look at this pull request as its been labeled with an integration (frontend) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 19, 2021
@spacegaier
Copy link
Copy Markdown
Member Author

Not stale

@github-actions github-actions bot removed the stale label Apr 22, 2021
@spacegaier spacegaier changed the title Add support for custom dark themes + color picker defaults Add support for custom dark themes Apr 27, 2021
@spacegaier spacegaier changed the title Add support for custom dark themes Add support for custom themes to use dark mode May 24, 2021
@spacegaier spacegaier deleted the custom-dark-themes branch May 25, 2021 11:26
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants