Add litterrobot integration#45886
Merged
Merged
Conversation
This was referenced Feb 3, 2021
70c347e to
c2317a4
Compare
c2317a4 to
bbd36a6
Compare
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
bdraco
reviewed
Feb 20, 2021
1857e91 to
3088bd8
Compare
Contributor
Author
Thanks for the thorough review. I'm made the suggested changes. |
bdraco
requested changes
Feb 22, 2021
bdraco
reviewed
Feb 22, 2021
Member
|
Once more small cleanup, otherwise LGTM |
…ady been configured for a username
Co-authored-by: J. Nick Koston <nick@koston.org>
…move unnecessary method in config_flow
3088bd8 to
094bc90
Compare
Contributor
Author
Should be ready for your final review! |
bdraco
reviewed
Feb 22, 2021
| @property | ||
| def name(self): | ||
| """Return the name of this entity.""" | ||
| return f"{self.robot.name} {self.entity_type}" |
Member
There was a problem hiding this comment.
There will be a trailing space here if the entity type is an empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add litterrobot component to integrate with a Litter-Robot connected, automatic, self-cleaning litter box.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: