Skip to content

Add litterrobot integration#45886

Merged
bdraco merged 9 commits into
home-assistant:devfrom
natekspencer:litterrobot
Feb 22, 2021
Merged

Add litterrobot integration#45886
bdraco merged 9 commits into
home-assistant:devfrom
natekspencer:litterrobot

Conversation

@natekspencer
Copy link
Copy Markdown
Contributor

@natekspencer natekspencer commented Feb 3, 2021

Proposed change

Add litterrobot component to integrate with a Litter-Robot connected, automatic, self-cleaning litter box.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Comment thread homeassistant/components/litterrobot/__init__.py Outdated
Comment thread homeassistant/components/litterrobot/config_flow.py Outdated
Comment thread homeassistant/components/litterrobot/config_flow.py Outdated
Comment thread homeassistant/components/litterrobot/config_flow.py Outdated
Comment thread homeassistant/components/litterrobot/config_flow.py Outdated
Comment thread homeassistant/components/litterrobot/hub.py Outdated
Comment thread homeassistant/components/litterrobot/hub.py Outdated
Comment thread homeassistant/components/litterrobot/hub.py Outdated
Comment thread homeassistant/components/litterrobot/hub.py
Comment thread homeassistant/components/litterrobot/hub.py Outdated
Comment thread homeassistant/components/litterrobot/manifest.json Outdated
Comment thread tests/components/litterrobot/test_vacuum.py Outdated
Comment thread tests/components/litterrobot/conftest.py Outdated
Comment thread homeassistant/components/litterrobot/hub.py Outdated
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments above.

@natekspencer
Copy link
Copy Markdown
Contributor Author

Please see comments above.

Thanks for the thorough review. I'm made the suggested changes.

@natekspencer natekspencer requested a review from bdraco February 21, 2021 23:23
Comment thread homeassistant/components/litterrobot/config_flow.py Outdated
Comment thread homeassistant/components/litterrobot/vacuum.py
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Feb 22, 2021

Once more small cleanup, otherwise LGTM

@natekspencer
Copy link
Copy Markdown
Contributor Author

Once more small cleanup, otherwise LGTM

Should be ready for your final review!

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread homeassistant/components/litterrobot/config_flow.py Outdated
@bdraco bdraco merged commit e70d896 into home-assistant:dev Feb 22, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 23, 2021
Comment thread homeassistant/components/litterrobot/config_flow.py
@property
def name(self):
"""Return the name of this entity."""
return f"{self.robot.name} {self.entity_type}"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be a trailing space here if the entity type is an empty string.

Comment thread tests/components/litterrobot/conftest.py
Comment thread tests/components/litterrobot/test_config_flow.py
Comment thread tests/components/litterrobot/test_init.py
Comment thread tests/components/litterrobot/test_vacuum.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants