Skip to content

Add node_status websocket API command to zwave_js#45325

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
cgarwood:zwjs_node_status
Jan 19, 2021
Merged

Add node_status websocket API command to zwave_js#45325
MartinHjelmare merged 2 commits intohome-assistant:devfrom
cgarwood:zwjs_node_status

Conversation

@cgarwood
Copy link
Copy Markdown
Member

Proposed change

Add a node_status websocket command to the zwave_js integration. Used to return the current status of a node for the Devices page in the frontend

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some small comments. We need to wait for github to resolve their current issues with actions before we merge.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit c1addde into home-assistant:dev Jan 19, 2021
@cgarwood cgarwood deleted the zwjs_node_status branch January 19, 2021 15:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants